From 37ad7e7589df4d1b78845b32cc3acf3c7d414956 Mon Sep 17 00:00:00 2001 From: Daniel Kolesa Date: Thu, 15 Apr 2021 20:59:30 +0200 Subject: [PATCH] update compiler compat note + lowercase windows.h in linenoise --- README.md | 5 ++++- tools/linenoise.hh | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d51b7c4..d33f661 100644 --- a/README.md +++ b/README.md @@ -114,7 +114,10 @@ The C++20 support does not have to be complete. These are the baselines * Clang 10 (with libstdc++ or libc++) * Microsoft Visual C++ 2019 -Older versions of either of these are known not to work. +Older compilers generally do not work out of box (but for example, GCC 9 +may work if you provide an `std::span` implementation; see the docs for +how, but keep in mind that the resulting library will have incompatible +ABI with newer standard library versions that do provide it). You will need [Meson](https://mesonbuild.com/) to build the project. Most Unix-like systems have it in their package management, on Windows there is diff --git a/tools/linenoise.hh b/tools/linenoise.hh index a55c984..2437deb 100644 --- a/tools/linenoise.hh +++ b/tools/linenoise.hh @@ -137,7 +137,7 @@ #ifndef NOMINMAX #define NOMINMAX #endif -#include +#include #include #ifndef STDIN_FILENO #define STDIN_FILENO (_fileno(stdin))